code.ivysaur.me/miqt
1
0
Fork 0
mirror of https://github.com/mappu/miqt.git synced 2025-03-12 02:20:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

genbindings: extract fixupProtectedReferences() to separate function

Browse Source
This commit is contained in:
mappu 2025-02-08 14:42:08 +13:00
parent d94f21f322
commit 1e26114255
1 changed files with 25 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
cmd/genbindings/emitcabi.go
View File

@ -1293,6 +1293,30 @@ extern "C" {
}
// FIXME(hack): In some platforms (Android Qt 5), instantiating a
// protected enum fails in friend context:
//
// QAbstractItemView::State _ret = self_cast->state();
// error: 'State' is a protected member of 'QAbstractItemView'
//
// @ref https://stackoverflow.com/q/52191903
// However, it works fine on most other platforms. Probably this
// is a GCC vs Clang difference.
fixupProtectedReferences := func(assignStmts string) string {
// Work around it for this specific class (fingers-crossed) by
// referencing the protected enum via its subclass name
ret := strings.Replace(assignStmts, c.ClassName+`::`, cppSubclassName(c)+`::`, -1)
// Also need to scan parent classes (e.g. QColumnView friend
// functions refer to its parent QAbstractItemView::State)
for _, classInherit := range c.AllInheritsClassInfo() {
ret = strings.Replace(ret, classInherit.Class.ClassName+`::`, cppSubclassName(c)+`::`, -1)
}
return ret
}
// Virtual override helpers
for _, m := range virtualMethods {
@ -1358,28 +1382,6 @@ extern "C" {
vbpreamble, vbforwarding := emitParametersCABI2CppForwarding(m.Parameters, "\t\t")
vbCallTarget := "self_cast->" + m.CppCallTarget() + "(" + vbforwarding + ")"
assignStmts := emitAssignCppToCabi("\treturn ", m.ReturnType, vbCallTarget)
// FIXME(hack): In some platforms, instantiating a protected
// enum fails in friend context:
//
// QAbstractItemView::State _ret = self_cast->state();
// error: 'State' is a protected member of 'QAbstractItemView'
//
// @ref https://stackoverflow.com/q/52191903
// However, it works fine on most other platforms. Probably this
// is a GCC vs Clang difference.
//
// Work around it for this specific class (fingers-crossed) by
// referencing the protected enum via its subclass name
assignStmts = strings.Replace(assignStmts, c.ClassName+`::`, cppSubclassName(c)+`::`, -1)
// Also need to scan parent classes (e.g. QColumnView friend
// functions refer to its parent QAbstractItemView::State)
for _, classInherit := range c.AllInheritsClassInfo() {
assignStmts = strings.Replace(assignStmts, classInherit.Class.ClassName+`::`, cppSubclassName(c)+`::`, -1)
}
//
ret.WriteString(
@ -1393,7 +1395,7 @@ extern "C" {
"\t\n" +
"\t*_dynamic_cast_ok = true;\n" +
"\t" + vbpreamble + "\n" +
assignStmts + "\n" +
fixupProtectedReferences(emitAssignCppToCabi("\treturn ", m.ReturnType, vbCallTarget)) + "\n" +
"}\n" +
"\n",
)