code.ivysaur.me/php2go
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

node: elide some more parens in assignment expressions

Browse Source
This commit is contained in:
mappu 2020-04-11 12:47:37 +12:00
parent 5105293ce6
commit 71a4efbbda
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
node.go
View File

@ -1541,7 +1541,7 @@ func (this *conversionState) convertAssignment(n *assign.Assign, isTopLevelState
return "", parseErr{dimf, err} return "", parseErr{dimf, err}
} }
ret := arrayVar + ` = append(` + arrayVar + `, ` + rvalue + `)` ret := arrayVar + ` = append(` + arrayVar + `, ` + removeParens(rvalue) + `)`
if isTopLevelStatement { if isTopLevelStatement {
ret += "\n" ret += "\n"
} }
@ -1559,6 +1559,7 @@ func (this *conversionState) convertAssignment(n *assign.Assign, isTopLevelState
// TODO this may need to use `:=` // TODO this may need to use `:=`
if isTopLevelStatement { if isTopLevelStatement {
rvalue = removeParens(rvalue) // safe in top-level assignment context
// If this is a simple expression (func call; indirect/method call; assignment of func/method call) then // If this is a simple expression (func call; indirect/method call; assignment of func/method call) then
// we need to propagate errors // we need to propagate errors