code.ivysaur.me
/
nmdc-telegramfrontend
1
0
Fork 0
Code Issues 26 Pull Requests Releases 2 Wiki Activity

DC messages lost - missing extra ratelimiting for submitting messages to TG #23

New Issue
Closed
opened 2019-05-17 06:07:26 +00:00 by mappu04 · 1 comment
mappu04 commented 2019-05-17 06:07:26 +00:00
Owner
Copy Link

Encountered this error today:

2019/05/17 04:20:44 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:21:16 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:21:48 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:22:21 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:22:53 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:23:25 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:23:57 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:24:29 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:25:01 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:25:33 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:26:05 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:26:38 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:27:10 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:27:42 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:28:14 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:28:46 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:29:18 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:29:50 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:30:22 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:30:55 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:31:27 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:31:59 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:32:31 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:33:03 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:33:35 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:34:07 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:34:39 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:35:11 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:35:44 Delivering public message to group chat: Too Many Requests: retry after 32
2019/05/17 04:36:16 Delivering public message to group chat: Too Many Requests: retry after 32

It's probably only a one-off.

The TG docs do say

The API will not allow more than ~30 messages to different users per second, if you go over that, you'll start getting 429 errors.

and we will exceed 30 with two messages in the same second. However it hasn't been a problem in the past.

Encountered this error today: ``` 2019/05/17 04:20:44 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:21:16 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:21:48 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:22:21 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:22:53 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:23:25 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:23:57 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:24:29 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:25:01 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:25:33 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:26:05 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:26:38 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:27:10 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:27:42 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:28:14 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:28:46 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:29:18 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:29:50 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:30:22 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:30:55 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:31:27 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:31:59 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:32:31 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:33:03 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:33:35 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:34:07 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:34:39 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:35:11 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:35:44 Delivering public message to group chat: Too Many Requests: retry after 32 2019/05/17 04:36:16 Delivering public message to group chat: Too Many Requests: retry after 32 ``` It's probably only a one-off. The TG docs do say > The API will not allow more than ~30 messages to different users per second, if you go over that, you'll start getting 429 errors. and we will exceed 30 with two messages in the same second. However it hasn't been a problem in the past.
mappu04 added the
bug
 label 2019-05-17 06:07:29 +00:00
mappu04 commented 2019-05-17 06:19:34 +00:00
Author
Owner
Copy Link

TG-side issue.

The current behaviour (retrying for 15 minutes) is probably sufficient outside exceptional cases.

We should still send an error back to DC users if the message really failed to be delivered but that can be followed up separately ( #24 ).

[TG-side issue](https://downdetector.com/status/telegram/news/248278-problems-at-telegram). The current behaviour (retrying for 15 minutes) is probably sufficient outside exceptional cases. We should still send an error back to DC users if the message really failed to be delivered but that can be followed up separately ( #24 ).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
v1.0.1
v1.0.0
Labels
Clear labels   
bug

   
wishlist
No Label
bug
wishlist
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: code.ivysaur.me/nmdc-telegramfrontend#23
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?